fix(frontend): replace Findings API response any with typed contract#1988
Open
SathvikaSingoti wants to merge 1 commit into
Open
fix(frontend): replace Findings API response any with typed contract#1988SathvikaSingoti wants to merge 1 commit into
SathvikaSingoti wants to merge 1 commit into
Conversation
utksh1
requested changes
Jul 9, 2026
utksh1
left a comment
utksh1
left a comment
Owner
There was a problem hiding this comment.
The type-tightening is good, but the new filter on finding.id === 'string' introduces a pagination bug. When a page contains only records without id, page never advances and hasMore stays true, causing the infinite-scroll effect to request the same page repeatedly.
Fix: advance page based on a successful page fetch, not on moreFindings.length > 0, or derive hasMore from API page metadata rather than rendered-item count after client-side filtering.
utksh1
added
level:beginner
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The Findings page cast the
getFindingsAPI response toanyin its initial fetch andloadMorecallbacks, which hid pagination/result shape mistakes from the type checker.getFindingsalready returns a typedFindingsResponse(withfindings?: FindingRecord[]) inapi.ts, so this PR traces that type through the Findings page instead of discarding it.Related Issues
Closes #1401
Type of Change
How Has This Been Tested?
(data: any)with(data: FindingsResponse)in the initial fetch effect and removed theany-adjacentas Finding[]blind cast inloadMore.FindingRecord.idisstring | undefined(shared type used across many endpoints), while the page's localFindingtype requiresid: string. Rather than weakening either type, both fetch paths now filter out any finding missing a valididbefore assigning state, since a finding without anidcan't be selected, checked, or reviewed anyway. This is stricter/safer than the previous blind cast.npm run typecheck- passes with no errors.npm run test- 537/537 tests passing across 61 files.npm run build- builds clean.bash scripts/check-artifacts.sh origin/main- no tracked generated artifacts or cache files in the diff.Checklist